Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BWC tests until they are supported by the distribution #2108

Closed
wants to merge 1 commit into from

Conversation

peternied
Copy link
Member

@peternied peternied commented Sep 26, 2022

Description

Disable BWC tests until they are supported by the distribution

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #2108 (b82bd8a) into main (1fc02ad) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2108      +/-   ##
============================================
+ Coverage     60.97%   60.99%   +0.02%     
- Complexity     3226     3227       +1     
============================================
  Files           256      256              
  Lines         18073    18073              
  Branches       3224     3224              
============================================
+ Hits          11020    11024       +4     
+ Misses         5475     5473       -2     
+ Partials       1578     1576       -2     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 35.75% <0.00%> (-0.25%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 95.45% <0.00%> (+2.27%) ⬆️
...urity/ssl/transport/SecuritySSLNettyTransport.java 66.66% <0.00%> (+4.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cliu123
Copy link
Member

cliu123 commented Sep 26, 2022

Assuming BWC test is being disabled temporarily, would it be better to just merge PRs that only have the known BWC test failures for now? Otherwise, we wouldn't know if new changes introduce new BWC test failures or only failed because of the known failures.
And we'd also need another PR to enable BWC later when 3.0 supports it. Keeping it running, we'd be able to know immediately when it gets fixed. WDYT? @opensearch-project/security

@peternied
Copy link
Member Author

We have been unable to move to v3.0 for months, and I don't foresee a quick resolution. The aim of this change is to start making incremental progress.

The follow up issues that were created capture reenabling the tests and getting guidance for how to reenable BWC tests (see description for links).

@cliu123 what would you recommend if we don't take this change?

@peternied
Copy link
Member Author

Good news! 2.4.0 is backwards compatible with 3.0.0, I am closing this PR in deference to #2112 that will rev main to 3.0.0

@peternied peternied closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable BWC tests once they are operational in our CI checks
4 participants