[Backport 2.x] Fix legacy check in SecurityAdmin #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fix legacy check in SecurityAdmin Signed-off-by: Craig Perkins <[email protected]> * Add unit test for legacy index check logic Signed-off-by: Craig Perkins <[email protected]> * Add SECURITY_ADMIN_TESTS to describe tests performed Signed-off-by: Craig Perkins <[email protected]> * Address lint error Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit f83a7e8)
Codecov Report
@@ Coverage Diff @@
## 2.x #2075 +/- ##
============================================
- Coverage 61.06% 61.00% -0.06%
+ Complexity 3231 3227 -4
============================================
Files 256 256
Lines 18074 18075 +1
Branches 3224 3225 +1
============================================
- Hits 11036 11027 -9
- Misses 5465 5469 +4
- Partials 1573 1579 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cliu123
approved these changes
Sep 7, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…ch-project#2075) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit f83a7e8) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f83a7e8 from #2052