Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testComplianceEnable supports variable number of audit messages #1920

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

peternied
Copy link
Member

Description

We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation. Then when
run inside GitHub Actions there would only be 2 messages. This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation.  Then when
run inside GitHub Actions there would only be 2 messages.  This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied requested a review from a team June 28, 2022 20:20
@peternied peternied self-assigned this Jun 28, 2022
@DarshitChanpura
Copy link
Member

@peternied Should this be backported to 2.x?

@peternied peternied merged commit 1904db5 into opensearch-project:main Jun 29, 2022
@peternied peternied deleted the testComplianceEnable branch June 29, 2022 19:15
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation.  Then when
run inside GitHub Actions there would only be 2 messages.  This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 1904db5)
peternied added a commit that referenced this pull request Jun 29, 2022
… (#1924)

We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation.  Then when
run inside GitHub Actions there would only be 2 messages.  This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 1904db5)

Co-authored-by: Peter Nied <[email protected]>
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
…search-project#1920)

We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation.  Then when
run inside GitHub Actions there would only be 2 messages.  This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
peternied added a commit that referenced this pull request Dec 6, 2022
Windows build and test support for 1.3

- Use most recent format of CI workflows from main
- Backport #2206
- Supply workarounds for JDK8 incompatible APIs for Encoding / Pattern matching (Thanks @cwperks!)
- Backport only freeport logic from #1638
- Backport #1758
- All updates to TestAuditlogImpl.java from main
  - #2180
  - #1935 
  - #1920
  - #1914
  - #1829 
  - And Targeted test updates for ComplianceAuditlogTest and BasicAuditlogTest to keep up with TestAuditlogImpl.java updates

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…search-project#1920) (opensearch-project#1924)

We were seeing test failures where on higher end computers there would
be duplicate audit messages for the index mapping creation.  Then when
run inside GitHub Actions there would only be 2 messages.  This doesn't
look like an overt product issue, overlogging of requests, but the test
case was not handling it well. Also improved the failure message response
for faster future debugging.

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 1904db5)

Co-authored-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants