Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from RC1 to the GA of OpenSearch 2.0 #1826

Merged
merged 5 commits into from
May 12, 2022
Merged

Switch from RC1 to the GA of OpenSearch 2.0 #1826

merged 5 commits into from
May 12, 2022

Conversation

peternied
Copy link
Member

@peternied peternied commented May 5, 2022 •
edited
Loading

Description

Switch from RC1 to the GA of OpenSearch 2.0

Issues

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from a team May 5, 2022 22:05
@peternied peternied added the backport 2.0 backport to 2.0 branch label May 5, 2022
@peternied peternied self-assigned this May 5, 2022
@peternied
Copy link
Member Author

This change won't work as is because the 2.0.0 build of OpenSearch has not been uploaded to maven, we are blocked until this has occurred.

@peternied peternied mentioned this pull request May 9, 2022
Closed
DarshitChanpura
DarshitChanpura previously approved these changes May 9, 2022
View reviewed changes
@peternied
Copy link
Member Author

peternied commented May 9, 2022 •
edited
Loading

Note, this is blocked on opensearch-project/opensearch-build#2100

The new build is available

@peternied
Copy link
Member Author

Note, I'm looking into a consistent failure with remote re-indexing

@peternied
Copy link
Member Author

Note, I'm looking into a consistent failure with remote re-indexing

Latest change (1d8ae25) resolves this issue, the document type filter should have been removed completely during the last set of changes

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #1826 (75c2260) into main (e189b7a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1826      +/-   ##
============================================
- Coverage     60.81%   60.79%   -0.02%     
+ Complexity     3187     3186       -1     
============================================
  Files           253      253              
  Lines         17931    17933       +2     
  Branches       3204     3204              
============================================
- Hits          10904    10902       -2     
  Misses         5450     5450              
- Partials       1577     1581       +4
Impacted Files Coverage Δ
...security/configuration/DlsFlsFilterLeafReader.java 61.74% <ø> (+1.45%) ⬆️
...org/opensearch/security/rest/TenantInfoAction.java 77.94% <0.00%> (-10.30%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 71.97% <0.00%> (-2.20%) ⬇️
...ensearch/security/ssl/DefaultSecurityKeyStore.java 67.63% <0.00%> (-0.03%) ⬇️
...iance/ComplianceIndexingOperationListenerImpl.java 62.31% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e189b7a...75c2260. Read the comment docs.

cliu123
cliu123 requested changes May 11, 2022
View reviewed changes
Copy link
Member

@cliu123 cliu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all the versions in bwc-test/build.gradle.

@peternied
Update BWC version as well
75c2260 
Signed-off-by: Peter Nied <[email protected]>
@peternied
Copy link
Member Author

Please update all the versions in bwc-test/build.gradle.

@cliu123 this is done, thanks for spotting

@cliu123 cliu123 merged commit 87a093f into opensearch-project:main May 12, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 12, 2022
@peternied @github-actions
Switch from RC1 to the GA of OpenSearch 2.0 (#1826)
729b252 
Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 87a093f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 12, 2022
Merged
peternied added a commit that referenced this pull request May 13, 2022
@opensearch-trigger-bot @peternied
Switch from RC1 to the GA of OpenSearch 2.0 (#1826) (#1837)
7d68429 
Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 87a093f)

Co-authored-by: Peter Nied <[email protected]>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
@peternied
Switch from RC1 to the GA of OpenSearch 2.0 (opensearch-project#1826)
b9d188c 
Signed-off-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarshitChanpura DarshitChanpura DarshitChanpura approved these changes

@cliu123 cliu123 cliu123 approved these changes

@davidlago davidlago davidlago approved these changes

Assignees

@peternied peternied

Labels
backport 2.0 backport to 2.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0.0][Distribution]Remove rc1 qualifier reference in your code of 2.0 branch
5 participants
@peternied @codecov-commenter @davidlago @cliu123 @DarshitChanpura