Remove sleep when waiting for node close #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each node in the cluster we were removing and then sleeping for 250ms. There is an API that we can wait on to be sure the node has closed or at least take action if the closure wasn't successful. For the usage, which is cleaning up all nodes, switching to a best effort mode that could wait the same 250ms or return faster. Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1722 +/- ##
=========================================
Coverage 62.87% 62.87%
- Complexity 3264 3266 +2
=========================================
Files 253 253
Lines 18096 18097 +1
Branches 3246 3246
=========================================
+ Hits 11377 11379 +2
+ Misses 5064 5062 -2
- Partials 1655 1656 +1
Continue to review full report at Codecov.
|
DarshitChanpura
approved these changes
Apr 1, 2022
|
@cliu123 Could I get a review on this pull request? |
|
@opensearch-project/security Could I get a second review? |
Sorry, I missed this message. |
|
LGTM! |
cliu123
approved these changes
Apr 6, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For each node in the cluster we were removing and then sleeping for
250ms. There is an API that we can wait on to be sure the node has
closed or at least take action if the closure wasn't successful.
For the usage, which is cleaning up all nodes, switching to a best
effort mode that could wait the same 250ms or return faster.
Testing
Tested in this PR's workflow, new runtime is 25 minutes down from 40, a 40% reduction in runtime.Tested in this PR's workflow, new runtime is 25 minutes, seeing this amount of time hit during other runs. While it might not provide a giant boost, I still think its worthwhile to avoid unreasoned sleeps.
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.