Centralize version settings #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single file is referenced and read for version settings, updated the build scripts and test script to read from this file. Added functionality and tests for build.version_qualifier parameter Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
davidlago
approved these changes
Mar 24, 2022
| - uses: actions/checkout@v2 | ||
|
|
||
| - id: security-plugin-version | ||
| uses: madhead/read-java-properties@66cc8c88f5c6f6069ebfb42586024dd6ffe2e451 |
There was a problem hiding this comment.
will this long string change at any point in future leading to a breaking change?
DarshitChanpura
approved these changes
Mar 24, 2022
24 tasks
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
* Centralize version settings A single file is referenced and read for version settings, updated the build scripts and test script to read from this file. Added functionality and tests for build.version_qualifier parameter Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A single file is referenced and read for version settings, updated
the build scripts and test script to read from this file.
Added functionality and tests for build.version_qualifier parameter
Issues Resolved
Testing
Added a new job that verifies the built artifact name correspond to the parameters passed to gradle
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.