Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to version 2.0.0.0 #1695

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Move to version 2.0.0.0 #1695

merged 1 commit into from
Mar 22, 2022

Conversation

peternied
Copy link
Member

@peternied peternied commented Mar 22, 2022

Description

Move to version 2.0.0.0

Keeping the default OpenSearch build version to 1.3.0 until we have
resolved the breaking changes from core.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Keeping the default OpenSearch build version to 1.3.0 until we have
resolved the breaking changes from core.

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied requested a review from a team March 22, 2022 16:59
@cliu123
Copy link
Member

cliu123 commented Mar 22, 2022

Is this PR only bumping security plugin version, but not bumping the OpenSearch dependency version? If so, can we clarify that in the PR title?

@peternied
Copy link
Member Author

@cliu123 The PR description and commit message has this information

@cliu123 cliu123 changed the title Move to version 2.0.0 Move to version 2.0.0.0 Mar 22, 2022
@cliu123
Copy link
Member

cliu123 commented Mar 22, 2022

@cliu123 The PR description and commit message has this information

Ok. The security plugin version will be 2.0.0.0. Updated the PR title and description.
LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #1695 (136a985) into main (e638c76) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1695      +/-   ##
============================================
- Coverage     62.94%   62.89%   -0.06%     
+ Complexity     3261     3259       -2     
============================================
  Files           253      253              
  Lines         18126    18087      -39     
  Branches       3258     3255       -3     
============================================
- Hits          11410    11375      -35     
+ Misses         5067     5063       -4     
  Partials       1649     1649              
Impacted Files Coverage Δ
.../org/opensearch/security/support/Base64Helper.java 67.85% <0.00%> (-4.78%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 73.07% <0.00%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e638c76...136a985. Read the comment docs.

@peternied peternied merged commit 2e1da49 into opensearch-project:main Mar 22, 2022
@peternied peternied deleted the 2.0 branch March 22, 2022 22:47
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Keeping the default OpenSearch build version to 1.3.0 until we have
resolved the breaking changes from core.

Signed-off-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants