Disable checkstyle until rules are enforced #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current checkstyle settings the build is done, but it doesn't prevent changes from being merged that contain checkstyle violations. We need to revisit these as a whole, saving 3 minutes of build time per leg until this work has been done. See opensearch-project#1659 Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
============================================
+ Coverage 64.56% 64.59% +0.02%
- Complexity 3239 3240 +1
============================================
Files 249 249
Lines 17479 17479
Branches 3096 3096
============================================
+ Hits 11286 11290 +4
+ Misses 4635 4631 -4
Partials 1558 1558
Continue to review full report at Codecov.
|
davidlago
approved these changes
Mar 4, 2022
DarshitChanpura
approved these changes
Mar 7, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
With the current checkstyle settings the build is done, but it doesn't prevent changes from being merged that contain checkstyle violations. We need to revisit these as a whole, saving 3 minutes of build time per leg until this work has been done. See opensearch-project#1659 Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current checkstyle settings the build is done, but it doesn't
prevent changes from being merged that contain checkstyle violations.
We need to revisit these as a whole, saving 3 minutes of build time per
leg until this work has been done.
Issues Resolved
See #1659
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.