Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure ML reserved roles and system indices #1654

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ylwu-amzn
Copy link
Contributor

Signed-off-by: Yaliang Wu [email protected]

Description

This PR is to configure ML reserved roles and system indices. This is to replace the old PR #1308

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    New feature

  • Why these changes are required?
    We need to release new ML plugin in 1.3

  • What is the old behavior before changes and new behavior after changes?
    We add two new reserved roles for ML plugin.
    We add two new system indices for ML plugin.

Testing

Test done on local single node cluster and on multi-node cluster on EC2.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #1654 (7034059) into main (ff40615) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1654      +/-   ##
============================================
- Coverage     64.59%   64.55%   -0.05%     
  Complexity     3214     3214              
============================================
  Files           247      247              
  Lines         17352    17352              
  Branches       3082     3082              
============================================
- Hits          11208    11201       -7     
- Misses         4594     4601       +7     
  Partials       1550     1550              
Impacted Files Coverage Δ
...org/opensearch/security/rest/TenantInfoAction.java 77.94% <0.00%> (-10.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff40615...7034059. Read the comment docs.

@peternied peternied added backport 1.x backport to 1.x branch v1.3.0 labels Mar 2, 2022
@davidlago davidlago added backport 1.3 backport to 1.3 branch and removed backport 1.x backport to 1.x branch labels Mar 2, 2022
@davidlago
Copy link

@peternied just check me but I think this should go to 1.3 not to 1.x

@peternied peternied merged commit 3638c6f into opensearch-project:main Mar 2, 2022
@peternied
Copy link
Member

@davidlago you are exactly right, I didn't see the backport 1.3 tag

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 2, 2022
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 3638c6f)
ylwu-amzn added a commit to ylwu-amzn/security-1 that referenced this pull request Mar 3, 2022
cliu123 pushed a commit that referenced this pull request Mar 3, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport to 1.3 branch v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants