-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Dev guide #1590
Merged
peternied
merged 7 commits into
opensearch-project:main
from
DarshitChanpura:dev-guide-update
Apr 5, 2022
Merged
Updates Dev guide #1590
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
41493dc
Updates Dev guide
DarshitChanpura c3ce697
Updates dev guide to account gradle migration
DarshitChanpura e46888d
Merge branch 'main' into dev-guide-update
DarshitChanpura feb0c41
Removes incorrect comment in dev guide
DarshitChanpura 42a1c21
Adds a line that notes the Java versions that we currently support
DarshitChanpura 457df27
Recommendationsons for the dev guide
peternied e08fe5b
Merge pull request #1 from peternied/dev-guide-update
DarshitChanpura File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to create a new issue
--insecure
feels like a bad option to advertise. After the script has finished running can we add a step to install the CA cert that was generated from the install script so this option can be removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something that we can discuss and set what needs to be displayed here.