Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to prevent timeouts in GitHub actions #1554

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

davidlago
Copy link

@davidlago davidlago commented Jan 4, 2022

Signed-off-by: Dave Lago [email protected]

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

This fix is coming from a particular workaround here to this issue

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:
    maven connection timeout in github action  apache/iotdb#3121

  3. Description of changes:

  4. Why these changes are required?
    CI times out occasionally

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
    This PR is the test :)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@davidlago davidlago requested a review from a team January 4, 2022 23:48
@@ -8,6 +8,8 @@ on:
branches:
- main
- opendistro-*
env:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It will be good to add an empty line before env to be consistent with the format in this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cliu123
cliu123 previously approved these changes Jan 5, 2022
@cliu123 cliu123 self-requested a review January 5, 2022 00:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1554 (1b6d40e) into main (7e002f2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1554      +/-   ##
============================================
- Coverage     64.89%   64.88%   -0.02%     
+ Complexity     3232     3231       -1     
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
- Hits          11250    11248       -2     
- Misses         4530     4531       +1     
- Partials       1555     1556       +1     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 47.26% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63558a1...1b6d40e. Read the comment docs.

Signed-off-by: Dave Lago <[email protected]>
@davidlago davidlago merged commit 07be53e into opensearch-project:main Jan 5, 2022
@davidlago davidlago deleted the fix-gh-actions-timeout branch January 5, 2022 12:18
davidlago pushed a commit to davidlago/security that referenced this pull request Jan 5, 2022
* Fix to prevent timeouts in GitHub actions

Signed-off-by: Dave Lago <[email protected]>
davidlago pushed a commit to davidlago/security that referenced this pull request Jan 5, 2022
* Fix to prevent timeouts in GitHub actions
Cherry-pick from 07be53e

Signed-off-by: Dave Lago <[email protected]>
davidlago pushed a commit to davidlago/security that referenced this pull request Jan 5, 2022
* Fix to prevent timeouts in GitHub actions

Signed-off-by: Dave Lago <[email protected]>
davidlago pushed a commit to davidlago/security that referenced this pull request Jan 5, 2022
Fix to prevent timeouts in GitHub actions
Fix to prevent timeouts in GitHub actions
Cherry-pick from 07be53e

Signed-off-by: Dave Lago <[email protected]>
davidlago pushed a commit to davidlago/security that referenced this pull request Jan 5, 2022
davidlago pushed a commit that referenced this pull request Jan 5, 2022
* Version bump to 1.2.4.0
* Fix to prevent timeouts in GitHub actions (#1554)
Cherry-pick from 07be53e

Signed-off-by: Dave Lago <[email protected]>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
* Fix to prevent timeouts in GitHub actions

Signed-off-by: Dave Lago <[email protected]>
gaobinlong pushed a commit to gaobinlong/security that referenced this pull request Aug 30, 2023
* Make the steps diagram honor the theme (opensearch-project#1538)

Signed-off-by: Miki <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Signed-off-by: Sam <[email protected]>

* Adding testing info do DEVELOPER_GUIDE.md

Signed-off-by: Sam <[email protected]>

* Minor changes and adding link

Signed-off-by: Sam <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Signed-off-by: Sam <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants