Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump log4j-core to 2.17.1 #1551

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

nsri19
Copy link
Contributor

@nsri19 nsri19 commented Jan 3, 2022

Signed-off-by: Nidhi Sridhar [email protected]

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

  2. Github Issue # or road-map entry, if available:
    Bump log4j to 2.17.1 #1548

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Nidhi Sridhar <[email protected]>
@nsri19 nsri19 requested a review from a team January 3, 2022 20:41
@dblock
Copy link
Member

dblock commented Jan 3, 2022

Backport to 1.2 please.

@codecov-commenter
Copy link

Codecov Report

Merging #1551 (9e497bc) into main (7e002f2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1551      +/-   ##
============================================
- Coverage     64.89%   64.88%   -0.02%     
+ Complexity     3232     3231       -1     
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
- Hits          11250    11248       -2     
- Misses         4530     4531       +1     
- Partials       1555     1556       +1     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 47.26% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e002f2...9e497bc. Read the comment docs.

@nsri19 nsri19 merged commit 63558a1 into opensearch-project:main Jan 3, 2022
@davidlago davidlago mentioned this pull request Jan 5, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants