Update CXF version to 3.4.5 #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozov
suggested changes
Dec 21, 2021
palashhedau
force-pushed
the
main
branch
2 times, most recently
from
4eedf97 to
e03ad58
Compare
|
Please upgrade CXF to 3.4.5 or above. See https://issues.apache.org/jira/browse/CXF-8555?jql=project%20%3D%20CXF%20AND%20text%20~%20%22escape%22 |
vrozov
reviewed
Dec 21, 2021
src/main/java/com/amazon/dlic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java
Outdated
Show resolved
Hide resolved
| @@ -193,6 +193,48 @@ public void decryptAssertionsTest() throws Exception { | |||
| Assert.assertEquals("horst", jwt.getClaim("sub")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void unescapeSamlEntitiesTest() throws Exception { | |||
| mockSamlIdpServer.setAuthenticateUser("ABC\\User1"); | |||
There was a problem hiding this comment.
Please add tests for more special characters (/, ").
palashhedau
force-pushed
the
main
branch
2 times, most recently
from
1e83433 to
ea01ea0
Compare
vrozov
previously approved these changes
Dec 21, 2021
vrozov
changed the title
hsiang9431-amzn
previously approved these changes
Dec 22, 2021
Signed-off-by: Palash Hedau <[email protected]>
palashhedau
dismissed stale reviews from hsiang9431-amzn and vrozov
via
f5a8845
hsiang9431-amzn
approved these changes
Dec 22, 2021
vrozov
approved these changes
Dec 22, 2021
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Palash Hedau <[email protected]> Co-authored-by: Palash Hedau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Bug Fix
Github Issue # or road-map entry, if available:
Description of changes:
Update CXF version to 3.4.5
Why these changes are required?
To correctly parse JWT with escaped characters
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from main branch? (If yes, please add backport PR # and commits #)
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.