[BUG] Fix the hardcode instance of check for NettyAttribute #3911
Comments
Gaganjuneja
added
bug
|
@reta, need your help in fixing this. Thanks! |
|
@Gaganjuneja #3514 was supposed to fix that |
|
@reta, yes, this line item was with you. Since that issue is closed so opened the new issue. |
3 tasks
reta
removed
the
untriaged
willyborankin
pushed a commit
that referenced
this issue
Jan 5, 2024
…PIs instead of typecasting (#3917) ### Description This is cherry-pick from #3514 to use the channel properties instead of type-casting ### Issues Resolved Closes #3911 Is this a backport? If so, please add backport PR # and/or commits # ### Testing The change is covered by existing test suites ### Check List - [X] New functionality includes testing - [X] New functionality has been documented - [X] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andriy Redko <[email protected]>
reta
added a commit
to reta/security
that referenced
this issue
Jan 5, 2024
…PIs instead of typecasting (opensearch-project#3917) This is cherry-pick from opensearch-project#3514 to use the channel properties instead of type-casting Closes opensearch-project#3911 Is this a backport? If so, please add backport PR # and/or commits # The change is covered by existing test suites - [X] New functionality includes testing - [X] New functionality has been documented - [X] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit b038f93)
dlin2028
pushed a commit
to dlin2028/security
that referenced
this issue
May 1, 2024
…PIs instead of typecasting (opensearch-project#3917) ### Description This is cherry-pick from opensearch-project#3514 to use the channel properties instead of type-casting ### Issues Resolved Closes opensearch-project#3911 Is this a backport? If so, please add backport PR # and/or commits # ### Testing The change is covered by existing test suites ### Check List - [X] New functionality includes testing - [X] New functionality has been documented - [X] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug?
Fix the hardcode
instance ofcheck for NettyAttribute. It fails if the HttpChannel is wrapped during the instrumentation.security/src/main/java/org/opensearch/security/filter/NettyAttribute.java
Line 28 in 26e62d5
How can one reproduce the bug?
Steps to reproduce the behavior:
What is the expected behavior?
It shouldn't fail if tracing is enabled.
What is your host/environment?
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.
The text was updated successfully, but these errors were encountered: