Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] org.opensearch.security.TransportUserInjectorIntegTest.testSecurityUserInjection is flaky #3729

Closed
cwperks opened this issue Nov 16, 2023 · 4 comments · Fixed by #3760
Closed

[Flaky Test] org.opensearch.security.TransportUserInjectorIntegTest.testSecurityUserInjection is flaky #3729

cwperks opened this issue Nov 16, 2023 · 4 comments · Fixed by #3760
Labels
bug Something isn't working flaky-test Flaky Test issue triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Nov 16, 2023

Seen in https://github.com/opensearch-project/security/actions/runs/6896058512/job/18761443796?pr=3727
@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized flaky-test Flaky Test issue and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 16, 2023
@stephen-crawford
Copy link
Contributor

[Triage] This is a flaky test which should be addressed by either removing the flaky behavior or replacing the test.

@stephen-crawford stephen-crawford added the triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. label Nov 20, 2023
@peternied
Copy link
Member

@peternied
Copy link
Member

@peternied
Copy link
Member

@cwperks cwperks mentioned this issue Nov 22, 2023
Merged
3 tasks
willyborankin pushed a commit that referenced this issue Nov 22, 2023
@cwperks
Switch UserInjectorPlugin to use reliable per-instance settings (#3760)
e9d3f26 
### Description

Fix flaky tests in TransportUserInjectorIntegTest by removing reliance
on a static variable that makes the test unpredictable. This instead
adds a setting in the UserInjectorPlugin and relies on each node that
has the plugin installed to supply this setting when instantiating the
node.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Test Fix

### Issues Resolved

- Fixes #3729

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Craig Perkins <[email protected]>
cwperks added a commit to cwperks/security that referenced this issue Nov 22, 2023
@cwperks
Switch UserInjectorPlugin to use reliable per-instance settings (open…
adebc61 
…search-project#3760)

Fix flaky tests in TransportUserInjectorIntegTest by removing reliance
on a static variable that makes the test unpredictable. This instead
adds a setting in the UserInjectorPlugin and relies on each node that
has the plugin installed to supply this setting when instantiating the
node.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Test Fix

- Fixes opensearch-project#3729

- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit e9d3f26)
prabhask5 pushed a commit to prabhask5/opensearch-security that referenced this issue Jan 11, 2024
@cwperks @prabhask5
Switch UserInjectorPlugin to use reliable per-instance settings (open…
d2a1972 
…search-project#3760)

### Description

Fix flaky tests in TransportUserInjectorIntegTest by removing reliance
on a static variable that makes the test unpredictable. This instead
adds a setting in the UserInjectorPlugin and relies on each node that
has the plugin installed to supply this setting when instantiating the
node.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Test Fix

### Issues Resolved

- Fixes opensearch-project#3729

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flaky-test Flaky Test issue triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch UserInjectorPlugin to use reliable per-instance settings cwperks/security
3 participants
@peternied @cwperks @stephen-crawford