-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptionalDataException in 1.3.13 #3531
Comments
@cwperks Since you fixed the issue in 2.2.0, can you please have a look and see if you think it's the same? |
[Triage] Hi @amitmun, thank you for filing this issue and leaving such great details. We will have someone follow-up shortly to get this addressed with likely backporting the fix. Action item:
|
Hi @amitmun, apologies for not replying sooner. I believe this is the same issue encountered in 2.x. I added a label for 1.3.14 to track this for the 1.3.14 release in December. The release window for 1.3.14 is Dev 5 - 12 so the bug fix will need to be backported before then. https://opensearch.org/releases.html |
#3725) ### Description This change backports #1970 in order to fix the OptionalDataException issue encountered on the 1.3.x line. The original change did not have any tests but #3637 added tests, so I backported those as well and the changes required to support them. This resulted in changes to the TestSecurityConfig.User class, the addition of a IndexStateIsEqualToMatcher and User.java. ### Issues Resolved - Resolves #3531 - Backports #1970 - Backports #3637 ### Check List - [X] New functionality includes testing - [ ] ~New functionality has been documented~ - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Peter Nied <[email protected]>
This was completed with #3725 |
This issue is helpful for me!! thank you!! |
What is the bug?
After upgrading from 1.3.12 to 1.3.13 we occasionally see
OptionalDataException
errors. The errors come and go, even without restarting the nodes.This issue has been discussed a lot in early v2 versions, until fixed on 2.2.0: #1961
But it seems it was introduced to 1.3 now.
I believe the commit that caused it is this one: 2d4a2ad
And the commit that solved the issue for 2.2.0 is this one: 0b2280f
Perhaps the same fix should be applied to 1.3, as I see it has not been applied: https://github.com/opensearch-project/security/blob/1.3.13.0/src/main/java/org/opensearch/security/user/User.java
How can one reproduce the bug?
See #1961 with all the details about the issue and reproduction.
What is the expected behavior?
Queries and indexing should not fail.
What is your host/environment?
Do you have any screenshots?
Logs:
The text was updated successfully, but these errors were encountered: