Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Break] Breaking changes from Add instrumentation in InboundHandler #10143 #3462

Closed
peternied opened this issue Oct 5, 2023 · 0 comments
Assignees
Labels
breaking This issue is or proposes a breaking change bug Something isn't working Severity-Blocker v2.11.0 Issues targeting the 2.11 release

Comments

@peternied
Copy link
Member

Repro by running ./gradlew compileJava in the security repo

> Task :compileJava
D:\a\security\security\src\main\java\org\opensearch\security\ssl\OpenSearchSecuritySSLPlugin.java:311: error: method does not override or implement a method from a supertype
    @Override
    ^
D:\a\security\security\src\main\java\org\opensearch\security\ssl\transport\SecuritySSLNettyTransport.java:87: error: constructor Netty4Transport in class Netty4Transport cannot be applied to given types;
        super(
        ^
  required: Settings,Version,ThreadPool,NetworkService,PageCacheRecycler,NamedWriteableRegistry,CircuitBreakerService,SharedGroupFactory,Tracer
  found: Settings,Version,ThreadPool,NetworkService,PageCacheRecycler,NamedWriteableRegistry,CircuitBreakerService,SharedGroupFactory
  reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors

> Task :compileJava FAILED

Additional Context

@peternied peternied added bug Something isn't working Severity-Blocker breaking This issue is or proposes a breaking change v2.11.0 Issues targeting the 2.11 release labels Oct 5, 2023
@reta reta self-assigned this Oct 5, 2023
@reta reta assigned Gaganjuneja and unassigned reta Oct 5, 2023
reta pushed a commit that referenced this issue Oct 5, 2023
### Description
Add tracer to fix the breaking issue.

### Issues Resolved
- #3462

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 5, 2023
### Description
Add tracer to fix the breaking issue.

### Issues Resolved
- #3462

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
(cherry picked from commit bfba97a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 5, 2023
### Description
Add tracer to fix the breaking issue.

### Issues Resolved
- #3462

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
(cherry picked from commit bfba97a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This issue is or proposes a breaking change bug Something isn't working Severity-Blocker v2.11.0 Issues targeting the 2.11 release
Projects
None yet
Development

No branches or pull requests

3 participants