Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unexpected Coverage Changes on ConfigurationRepository & ComplianceIndexingOperationListenerImpl #3255

Open
peternied opened this issue Aug 28, 2023 · 0 comments
Open

[BUG] Unexpected Coverage Changes on ConfigurationRepository & ComplianceIndexingOperationListenerImpl #3255

peternied opened this issue Aug 28, 2023 · 0 comments
Labels
bug Something isn't working good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

peternied commented Aug 28, 2023 •
edited
Loading

What is the bug?

There are several classes that are seeing random behavior in code coverage reports. Test should be added/modified to ensure these code paths are always exercised - keeping codecov results useful.

image

Codecov [Report Link]
Codecov [Indirect Coverage Changes]

How can one reproduce the bug?

  1. Create a pull request that only changes markdown file
  2. Look at the checks for the pull requset
  3. See the codecov check
  4. See error that coverage has dropped .0X%

What is the expected behavior?
Code coverage should not fluctuate, testing should be deterministic and 'exhaustive'

Do you have any additional context?
@peternied peternied added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 28, 2023
peternied added a commit that referenced this issue Aug 28, 2023
@peternied
Add new inconsistant coverage fles
b095ca8 
Created #3255 for
follow up

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied mentioned this issue Aug 28, 2023
Merged
@peternied peternied added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 28, 2023
@davidlago davidlago added the good first issue These are recommended starting points for newcomers looking to make their first contributions. label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peternied @davidlago