-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Filter internal users for Service Accounts and add associated API #2704
Comments
Hi @scrawfor99 The preliminary code that you provided in the issue description returns only the list of names of the accounts of the specified type, but the existing implementations on internalUsersAPI return the full account details. Can you confirm if the objective on this is I believe the latter is more appropriate to keep in line with existing functionality, but just want to confirm. Thanks |
Confirmed during last week's call that the full account details is the correct approach. PR was refactored to reflect this |
Signed-off-by: Sam <[email protected]>
…2786) ### Description Update UserAPIAction to Filter internal accounts and Service accounts. Dashboards Plugin changes via PR opensearch-project/security-dashboards-plugin#1502 ### Issues Resolved - Resolves #2704 ### Testing Unit Tests created ### Check List - [x] New functionality includes testing - [ ] New functionality has been documented - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: scosta <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Sam <[email protected]> Signed-off-by: Sam <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Reopened as the PR on the dashboards side opensearch-project/security-dashboards-plugin#1502 still needs to be merged/reviewed |
Pr merged, can be closed |
As a follow-up to #2594, a filtering option can be added to the existing internal users functionality. The filtering should allow a client to fetch just true internal user (not service) accounts or just service accounts. This filtering should be applied to the backend as well as the internal users list capabilities of the frontend code. An API route will need to be added to the
handleGet
method of theinternalUsersAPI
since there is not currently group filtering functionality.The backend logic can look something like this inside the
UserService
:For the frontend logic, the PR will need to extend the existing code that fetches the internal users and displays it as part of the Security tab.
Completion of this issue should look like two PR:
One in the backend code base that introduces the filtering capabilities shown above as well as the associated API routes.
One in the frontend code base that updates the internal users tab to allow for filtering the shown users based on whether they are service accounts or not.
The text was updated successfully, but these errors were encountered: