Moves tests to correct class

Signed-off-by: Darshit Chanpura <[email protected]>
opensearch-project · Sep 26, 2023 · db6efd8 · db6efd8
1 parent 054dc73
commit db6efd8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 18 deletions.
diff --git a/src/test/java/org/opensearch/security/auth/limiting/AddressBasedRateLimiterTest.java b/src/test/java/org/opensearch/security/auth/limiting/AddressBasedRateLimiterTest.java
@@ -22,26 +22,26 @@
 import org.opensearch.common.settings.Settings;
 import org.opensearch.security.user.AuthCredentials;
 
+import java.net.InetAddress;
+
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
 public class AddressBasedRateLimiterTest {
 
-    private final static byte[] PASSWORD = new byte[] { '1', '2', '3' };
-
     @Test
     public void simpleTest() throws Exception {
         Settings settings = Settings.builder().put("allowed_tries", 3).build();
 
-        UserNameBasedRateLimiter rateLimiter = new UserNameBasedRateLimiter(settings, null);
+        AddressBasedRateLimiter rateLimiter = new AddressBasedRateLimiter(settings, null);
 
-        assertFalse(rateLimiter.isBlocked("a"));
-        rateLimiter.onAuthFailure(null, new AuthCredentials("a", PASSWORD), null);
-        assertFalse(rateLimiter.isBlocked("a"));
-        rateLimiter.onAuthFailure(null, new AuthCredentials("a", PASSWORD), null);
-        assertFalse(rateLimiter.isBlocked("a"));
-        rateLimiter.onAuthFailure(null, new AuthCredentials("a", PASSWORD), null);
-        assertTrue(rateLimiter.isBlocked("a"));
+        assertFalse(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
+        rateLimiter.onAuthFailure(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 }), null, null);
+        assertFalse(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
+        rateLimiter.onAuthFailure(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 }), null, null);
+        assertFalse(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
+        rateLimiter.onAuthFailure(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 }), null, null);
+        assertTrue(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
 
     }
 }
diff --git a/src/test/java/org/opensearch/security/auth/limiting/UserNameBasedRateLimiterTest.java b/src/test/java/org/opensearch/security/auth/limiting/UserNameBasedRateLimiterTest.java
@@ -22,25 +22,28 @@
 import org.junit.Test;
 
 import org.opensearch.common.settings.Settings;
+import org.opensearch.security.user.AuthCredentials;
 
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
 public class UserNameBasedRateLimiterTest {
 
+    private final static byte[] PASSWORD = new byte[] { '1', '2', '3' };
+
     @Test
     public void simpleTest() throws Exception {
         Settings settings = Settings.builder().put("allowed_tries", 3).build();
 
-        AddressBasedRateLimiter rateLimiter = new AddressBasedRateLimiter(settings, null);
+        UserNameBasedRateLimiter rateLimiter = new UserNameBasedRateLimiter(settings, null);
 
-        assertFalse(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
-        rateLimiter.onAuthFailure(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 }), null, null);
-        assertFalse(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
-        rateLimiter.onAuthFailure(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 }), null, null);
-        assertFalse(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
-        rateLimiter.onAuthFailure(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 }), null, null);
-        assertTrue(rateLimiter.isBlocked(InetAddress.getByAddress(new byte[] { 1, 2, 3, 4 })));
+        assertFalse(rateLimiter.isBlocked("a"));
+        rateLimiter.onAuthFailure(null, new AuthCredentials("a", PASSWORD), null);
+        assertFalse(rateLimiter.isBlocked("a"));
+        rateLimiter.onAuthFailure(null, new AuthCredentials("a", PASSWORD), null);
+        assertFalse(rateLimiter.isBlocked("a"));
+        rateLimiter.onAuthFailure(null, new AuthCredentials("a", PASSWORD), null);
+        assertTrue(rateLimiter.isBlocked("a"));
 
     }
 }