-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes broken main build which was caused due to version mismatch #989
Fixes broken main build which was caused due to version mismatch #989
Conversation
66fedf8
to
d0075b1
Compare
This is a much better than the change I had pointed to the 2.0 branch |
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 247 +5
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54 Continue to review full report at Codecov.
|
@@ -5,6 +5,10 @@ on: [push, pull_request] | |||
env: | |||
TEST_BROWSER_HEADLESS: 1 | |||
CI: 1 | |||
OPENSEARCH_DASHBOARDS_VERSION: 2.0 | |||
OPENSEARCH_CORE_VERSION: 2.0 | |||
OPENSEARCH_CORE_VERSION_QUALIFIER: ${{OPENSEARCH_CORE_VERSION}}.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests fail because these variables are not declared successfully. You can reference to here and declare the env variables in the same way to make them available.
786fb96
to
f2aeaea
Compare
@@ -5,6 +5,8 @@ on: [push, pull_request] | |||
env: | |||
TEST_BROWSER_HEADLESS: 1 | |||
CI: 1 | |||
OPENSEARCH_DASHBOARDS_VERSION: 2.0 | |||
OPENSEARCH_CORE_VERSION: 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 2 variables need to be defined with echo... >> $GITHUB_ENV
too to be available for reference.
c5c89bf
to
0ba1aad
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
3498dea
to
4dddfa7
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
4dddfa7
to
80f90d6
Compare
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 426ec61)
…nsearch-project#989) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 426ec61) Signed-off-by: cliu123 <[email protected]>
… (#995) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 426ec61) Signed-off-by: cliu123 <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Description
Fixes broken main build
Issues Resolved
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.