Remove redundant DCO check in favor of the GitHub app #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]>
DarshitChanpura
approved these changes
Apr 27, 2022
|
The integration test failed due to versioning issue here Also, should we create a PR against the main branch too? |
…r the tests Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.3 #972 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 87 87
Lines 1906 1906
Branches 247 242 -5
=======================================
Hits 1372 1372
Misses 480 480
Partials 54 54 Continue to review full report at Codecov.
|
I thought we had removed it, I'll create one for this now |
3 tasks
davidlago
approved these changes
May 2, 2022
DarshitChanpura
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are seeing DCO failures when different domained are coming back for user email addresses from the basic dco script, the DCO GitHub App handles this better and it I can be bypassed by maintainers instead of 'force' merging the change to the repository.
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.