Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] Select tenant popup only appears when multi-tenacy is enabled #970

Merged
merged 2 commits into from
May 16, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ec59de0 from #965

The current behavoir is that all users will see a message to switch
tenants and if multi-tenancy is disabled, that message will be prompting
the user to ask the admin to enable the feature.  This is causing users
pain that are not interested in using the tenancy features.

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit ec59de0)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team April 26, 2022 13:23
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventing this change from being merged until the 2.0.0-rc1 release has been created.

@peternied peternied added the v2.0.0-GeneralAvailability For changes that should only be included in the 2.0.0-GA release label Apr 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #970 (4cc8db2) into 2.0 (d9cdb82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.0     #970   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      247      247           
=======================================
  Hits         1375     1375           
  Misses        477      477           
  Partials       54       54           
Impacted Files Coverage Δ
...-plugin/public/apps/account/account-nav-button.tsx 67.85% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cdb82...4cc8db2. Read the comment docs.

@peternied peternied merged commit 74dc2ab into 2.0 May 16, 2022
@peternied peternied deleted the backport/backport-965-to-2.0 branch November 30, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.0.0-GeneralAvailability For changes that should only be included in the 2.0.0-GA release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants