Fix 'openserach' typo in constants.tsx #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, @camAtGitHub! @ylwu-amzn could you please take a look from the ML commons repo's perspective and see if/how we can merge this change? |
ylwu-amzn
reviewed
Apr 20, 2022
| @@ -96,7 +96,7 @@ export const CLUSTER_PERMISSIONS: string[] = [ | |||
| 'cluster:admin/opensearch/ml/models/get', | |||
| 'cluster:admin/opensearch/ml/models/search', | |||
| 'cluster:admin/opensearch/ml/predict', | |||
| 'cluster:admin/openserach/ml/stats/nodes', | |||
There was a problem hiding this comment.
Thanks for fixing this. The fix is ok for ml-commons. Check ml-commons code https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/action/stats/MLStatsNodesAction.java#L13 and https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/constant/CommonValue.java#L9
Signed-off-by: Cam McKenzie <[email protected]>
cliu123
approved these changes
Apr 21, 2022
DarshitChanpura
approved these changes
Apr 21, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Cam McKenzie <[email protected]> (cherry picked from commit d336f03)
3 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Cam McKenzie <[email protected]> (cherry picked from commit d336f03)
ylwu-amzn
pushed a commit
to ylwu-amzn/security-dashboards-plugin
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Cam <[email protected]>
ylwu-amzn
pushed a commit
to ylwu-amzn/security-dashboards-plugin
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Cam <[email protected]>
3 tasks
peterzhuamazon
added a commit
to peterzhuamazon/security-dashboards-plugin
that referenced
this pull request
Apr 21, 2022
Signed-off-by: Peter Zhu <[email protected]>
DarshitChanpura
pushed a commit
to DarshitChanpura/security-dashboards-plugin
that referenced
this pull request
May 2, 2022
Signed-off-by: Cam McKenzie <[email protected]> (cherry picked from commit d336f03) Signed-off-by: Darshit Chanpura <[email protected]>
peternied
pushed a commit
that referenced
this pull request
May 3, 2022
Signed-off-by: Cam McKenzie <[email protected]> (cherry picked from commit d336f03)
peternied
pushed a commit
that referenced
this pull request
May 3, 2022
Signed-off-by: Peter Nied <[email protected]>
peternied
pushed a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cam McKenzie [email protected]
Description
Fix 'openserach' typo.
This commit has not been tested, however I scanned 'security', 'security-dashboard-plugins, and 'opensearch' repos.
security and its dashboards are the only two occurrences of the word.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.