Enforce authentication on api/status route by default #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 242
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54 Continue to review full report at Codecov.
|
cliu123
force-pushed
the
enforce_authentication_on_status_api_by_default
branch
from
3271a31
to
9969aa2
Compare
cliu123
changed the title
api/status route by default
cliu123
changed the title
api/status route by default
cliu123
force-pushed
the
enforce_authentication_on_status_api_by_default
branch
3 times, most recently
from
e707034
to
4391d44
Compare
Signed-off-by: cliu123 <[email protected]>
cliu123
force-pushed
the
enforce_authentication_on_status_api_by_default
branch
from
4391d44
to
71c89bd
Compare
davidlago
approved these changes
Apr 13, 2022
DarshitChanpura
approved these changes
Apr 14, 2022
kavilla
added a commit
to kavilla/opensearch-build
that referenced
this pull request
Apr 16, 2022
Allow for the API status for OSD not to enforce auth. opensearch-project/security-dashboards-plugin#943 Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
1 task
kavilla
added a commit
to kavilla/opensearch-build
that referenced
this pull request
Apr 16, 2022
Allow for the API status for OSD not to enforce auth. opensearch-project/security-dashboards-plugin#943 Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
peterzhuamazon
added a commit
to peterzhuamazon/security-dashboards-plugin
that referenced
this pull request
Apr 16, 2022
…arch-project#943)" This reverts commit 6d6c5b7. Signed-off-by: Peter Zhu <[email protected]>
cliu123
pushed a commit
that referenced
this pull request
Apr 16, 2022
…#950) This reverts commit 6d6c5b7. Signed-off-by: Peter Zhu <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chang Liu [email protected]
Description
Enforce authentication on
api/statusroute by default.Category
Bug fix
Why these changes are required?
Secure
api/statusrouteWhat is the old behavior before changes and new behavior after changes?
Old behavior:
api/statusroute bypasses authentication by default.New behavior:
Enforce authentication on
api/statusroute by default unless user explicitly configuresapi/statusasopensearch_security.auth.unauthenticated_routes: ["/api/status"].Issues Resolved
#945
Testing
ITs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.