Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces sasslint to stylelint to conform to changes in core dashboards #933

Conversation

DarshitChanpura
Copy link
Member

Testing

run yarn lint. It should pass without any errors

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura requested a review from a team April 6, 2022 02:42
@peternied
Copy link
Member

@DarshitChanpura The CI checks are failing because of Error: Cannot find module '/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/scripts/stylelint' is this something that you can fix independent of moving to the new dashboard version?

@DarshitChanpura
Copy link
Member Author

@DarshitChanpura The CI checks are failing because of Error: Cannot find module '/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/scripts/stylelint' is this something that you can fix independent of moving to the new dashboard version?

Good Point! I think I will have to merge these changes in version bump PR and move forward from there

@DarshitChanpura
Copy link
Member Author

Closing this PR now as these changes are covered in #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants