-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps version of 1.3 branch to 1.3.1.0 #927
Bumps version of 1.3 branch to 1.3.1.0 #927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, I missed this when reviewing before! If you look the integration test job is only run on the main branch (so not on this PR), can we remove that to be sure these changes work?
…or branches Signed-off-by: Darshit Chanpura <[email protected]>
24b6991
to
ce23455
Compare
@@ -1,26 +1,18 @@ | |||
name: Integration Tests | |||
|
|||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section needs to be kept, but the filters should be removed, it could look like this:
on: [push, pull_request]
https://github.com/opensearch-project/security/blob/main/.github/workflows/ci.yml#L3
I'm going to close this PR as it is a duplicate of #925
I will address this in a new PR |
@DarshitChanpura I think you needed to resolve this PR before moving forward, I would suggest reopenning |
The changes are required are proposed in this PR: #930 . I don't think re-opening this PR would do any different |
Description
Bumps version to 1.3
Category
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.