Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version of 1.3 branch to 1.3.1.0 #927

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Mar 25, 2022

Description

Bumps version to 1.3

Category

Maintenance

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura requested a review from a team March 25, 2022 15:09
@DarshitChanpura DarshitChanpura changed the title Bumps version to 1.3.1.0 Bumps version of 1.3 branch to 1.3.1.0 Mar 25, 2022
davidlago
davidlago previously approved these changes Mar 25, 2022
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I missed this when reviewing before! If you look the integration test job is only run on the main branch (so not on this PR), can we remove that to be sure these changes work?

@@ -1,26 +1,18 @@
name: Integration Tests

on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs to be kept, but the filters should be removed, it could look like this:

on: [push, pull_request]

https://github.com/opensearch-project/security/blob/main/.github/workflows/ci.yml#L3

@DarshitChanpura
Copy link
Member Author

I'm going to close this PR as it is a duplicate of #925

Doh, I missed this when reviewing before! If you look the integration test job is only run on the main branch (so not on this PR), can we remove that to be sure these changes work?

I will address this in a new PR

@peternied
Copy link
Member

@DarshitChanpura I think you needed to resolve this PR before moving forward, I would suggest reopenning

@DarshitChanpura
Copy link
Member Author

@DarshitChanpura I think you needed to resolve this PR before moving forward, I would suggest reopenning

The changes are required are proposed in this PR: #930 . I don't think re-opening this PR would do any different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants