-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump to 2.0.0.0-SNAPSHOT #892
Conversation
Signed-off-by: Dave Lago <[email protected]>
Needs opensearch-project/security#1577 to merge and 2.0.0.0-SNAPSHOT artifacts of the security plugin to be uploaded in order to pass CI after updating the URLS here |
Signed-off-by: Dave Lago <[email protected]>
tar -xzf opensearch-*.tar.gz | ||
rm -f opensearch-*.tar.gz | ||
|
||
- name: Download OpenSearch Security Plugin | ||
run: wget -O opensearch-security.zip https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/488/linux/x64/builds/opensearch/plugins/opensearch-security-1.3.0.0.zip | ||
run: wget -O opensearch-security.zip https://TBD/opensearch-security-2.0.0.0.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update after opensearch-project/security#1577 produces a 2.0.0 artifact
Signed-off-by: Dave Lago <[email protected]>
@@ -50,7 +50,7 @@ jobs: | |||
with: | |||
path: OpenSearch-Dashboards | |||
repository: opensearch-project/OpenSearch-Dashboards | |||
ref: '1.x' | |||
ref: '2.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this branch exist?
I thought 2.0
were on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct, updating
Signed-off-by: Dave Lago <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the integration tests ran with this change, was that expected?
@@ -0,0 +1 @@ | |||
14.18.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to explicitly declare or can we transitivity pick this up from OpenSearch Dashboards version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, yeah... we do for the integration tests run here. I honestly just added it as a convenience so that it stands by itself, but to be honest I'm not sure if we ever build this project without being "nested" inside of the Dashboards codebase.
No, this is the first |
Also, had they run, they would have failed left and right as @hsiang9431-amzn is still looking into #875 |
Signed-off-by: Dave Lago [email protected]
Description
Creating the
2.0
branch with a version bump. Once tests pass this will become the newmain
andmain
will become1.x
, to align with the branching strategy of the main project.Issues Resolved
N/A
Testing
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.