-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom build script to support different cypress version #2027
Conversation
Signed-off-by: Derek Ho <[email protected]>
Are there any testing steps that can be added to the PR description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @derek-ho. Can we rename the file to build-opensearch-dashboards.sh? unless this will be the only build script in the repo.
It needs to be named this way according to: https://github.com/opensearch-project/opensearch-build/blob/6f53f232978213fd3f278aece2f06c4f19e53549/ONBOARDING.md?plain=1#L26 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 380 380
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit e35f7f7)
…2028) Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit e35f7f7) Co-authored-by: Derek Ho <[email protected]>
Description
Adds custom build script to allow for different cypress version from core.
Category
Fix: #1786 hopefully
Why these changes are required?
Build repo not making the change so seeing if this will fix it from our end.
What is the old behavior before changes and new behavior after changes?
Should build successfully after
Issues Resolved
Fix: #1786
Testing
None possible, this would be picked up by the build infra
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.