-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tenant tab when disabled via yaml #1960
Remove tenant tab when disabled via yaml #1960
Conversation
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
=======================================
Coverage 69.91% 69.91%
=======================================
Files 97 96 -1
Lines 2506 2513 +7
Branches 336 339 +3
=======================================
+ Hits 1752 1757 +5
Misses 673 673
- Partials 81 83 +2 ☔ View full report in Codecov by Sentry. |
Failing cypress test case should be changed to instead assert that tenancy tab does not show up on the left nav menu. That test is not being run at release time, will move that over in a separate PR |
Test fix is within this PR: opensearch-project/opensearch-dashboards-functional-test#1276 |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
a202d48
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1960-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a202d4875ae42729994b64fb38090af6b7f1ae7a
# Push it to GitHub
git push --set-upstream origin backport/backport-1960-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@derek-ho Could you create a manual backport? |
--------- Signed-off-by: Derek Ho <[email protected]>
* Remove tenant tab when disabled via yaml (#1960) --------- Signed-off-by: Derek Ho <[email protected]> * Update snapshot Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Description
Removes tenant tab from showing up in the left nav, and also doesn't register it as a page at
/tenants
if tenancy is turned off/not enabled via yaml. Since workspaces is coming and no active development being done on the tenancy feature, this is appropriate. Also gets rid of a few "ghost" routes and UI components related to different tenancy tabs (manage vs configure), since these were not connected to any UI component and would only be hit unexpectedly or if people know the exact route to put in the URL.Category
Enhancement
Why these changes are required?
Fix: #1959
What is the old behavior before changes and new behavior after changes?
New behavior: when multi tenancy is turned off via dashboards yaml, tenancy does not show up in the left nav, explicitly navigating to '/tenants' does not do anything
Issues Resolved
Fix: #1959
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.