Add indices:data/read/search/template/render to cluster permissions dropdown #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropdown Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
peternied
reviewed
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 94 94
Lines 2404 2404
Branches 318 318
=======================================
Hits 1613 1613
Misses 713 713
Partials 78 78 ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Jan 5, 2024
derek-ho
approved these changes
Jan 5, 2024
DarshitChanpura
approved these changes
Jan 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ropdown (#1725) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 780b3aa)
DarshitChanpura
added a commit
that referenced
this pull request
Jan 18, 2024
…ropdown (#1725) (#1732) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 780b3aa) Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the cluster permission to render a search template in the cluster permissions dropdown.
Render search template was made into a separate transport action in core in this PR
Category
Maintenance
Issues Resolved
Related: opensearch-project/security#3672
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.