-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cypress E2E workflow to reflect changes to default admin password #1714
Update cypress E2E workflow to reflect changes to default admin password #1714
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 94 94
Lines 2404 2404
Branches 318 318
=======================================
Hits 1613 1613
Misses 713 713
Partials 78 78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we follow up with a fix to pull the password from the env rather than hardcode it into the cypress config?
…ord (#1714) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 96a449f)
…ord (#1714) (#1719) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 96a449f) Co-authored-by: Darshit Chanpura <[email protected]>
…ord (opensearch-project#1714) (opensearch-project#1719) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 96a449f) Co-authored-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]>
Description
Updates the github cypress test workflow to reflect to changes in admin password.
Category
Refactoring
Why these changes are required?
Cypress E2E workflow will be broken without this change.
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.