Add search pipeline action permissions #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search pipelines have been generally available since OpenSearch 2.9. We should make it easy to manage permissions for search pipeline CRUD operations. Signed-off-by: Michael Froh <[email protected]>
msfroh
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
=======================================
Coverage 66.63% 66.63%
=======================================
Files 94 94
Lines 2395 2395
Branches 324 319 -5
=======================================
Hits 1596 1596
Misses 728 728
Partials 71 71 ☔ View full report in Codecov by Sentry. |
cwperks
approved these changes
Nov 21, 2023
stephen-crawford
approved these changes
Nov 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Search pipelines have been generally available since OpenSearch 2.9. We should make it easy to manage permissions for search pipeline CRUD operations. Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit d5a6626)
RyanL1997
pushed a commit
that referenced
this pull request
Nov 22, 2023
Search pipelines have been generally available since OpenSearch 2.9. We should make it easy to manage permissions for search pipeline CRUD operations. Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit d5a6626) Co-authored-by: Michael Froh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds three new actions to the list of available cluster permissions. These are derived from:
Category
Enhancement
Why these changes are required?
Search pipelines have been generally available since OpenSearch 2.9. We should make it easy to manage permissions for search pipeline CRUD operations.
What is the old behavior before changes and new behavior after changes?
The security dashboards plugin doesn't help users manage permissions on search pipeline GET, PUT, and DELETE operations without this change.
With this change, the three actions should be available through the UI as assignable permissions.
Issues Resolved
Relates to opensearch-project/security#3736
Testing
None yet
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.