[Backport 2.x] [Refactor-1160] Different Values Pointing to Basic Auth, Need to Unify #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
#1619) * finished ticket Signed-off-by: Prabhas Kurapati <[email protected]> * fixed invalid auth type error Signed-off-by: Prabhas Kurapati <[email protected]> * fixed unit tests Signed-off-by: Prabhas Kurapati <[email protected]> * made requested changes Signed-off-by: Prabhas Kurapati <[email protected]> * updated saml to AuthType.SAML + fixed basicauth test Signed-off-by: Prabhas Kurapati <[email protected]> --------- Signed-off-by: Prabhas Kurapati <[email protected]> (cherry picked from commit 2131598)
cwperks
approved these changes
Nov 13, 2023
|
Looking into unit test failures: |
This was referenced Nov 14, 2023
Merged
DarshitChanpura
approved these changes
Nov 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1649 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 93 93
Lines 2344 2344
Branches 317 317
=======================================
Hits 1554 1554
Misses 720 720
Partials 70 70 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2131598 from #1619