Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the version parsing command's regex to handle double digits minor versions #1537

Merged

Conversation

RyanL1997
Copy link
Collaborator

Description

Change the version parsing command's regex to handle double digits minor versions

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Enhancement

Issues Resolved

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…le digits of minor versions

Signed-off-by: Ryan Liang <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1537 (96b521e) into main (95f316a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1537   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files          93       93           
  Lines        2328     2328           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        722      722           
  Partials       68       68           

@cwperks
Copy link
Member

cwperks commented Aug 3, 2023

Can another maintainer review this PR?

@peternied peternied merged commit fbfe8d0 into opensearch-project:main Aug 3, 2023
samuelcostae pushed a commit to samuelcostae/security-dashboards-plugin that referenced this pull request Aug 10, 2023
…le digits of minor versions (opensearch-project#1537)

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Sam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants