[Backport 1.3] Add the tenant into the short URL once the short URL is resolved (#1462) #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsearch-project#1462) * More information added Signed-off-by: leanneeliatra <[email protected]> * More information added Signed-off-by: leanneeliatra <[email protected]> * fixed linting errors Signed-off-by: leanneeliatra <[email protected]> * Removing Prerequisite Checks Workflow (opensearch-project#1456) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Removing Prerequisite Checks Workflow (opensearch-project#1456) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Removing Prerequisite Checks Workflow (opensearch-project#1456) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Extracting function to tenant_resolver and adding more appropriate comments. Signed-off-by: leanneeliatra <[email protected]> * lint errors fixed Signed-off-by: leanneeliatra <[email protected]> * Use version from package.json for integration tests (opensearch-project#1463) * Use version from package.json for integration tests Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Adds 2.8 release notes (opensearch-project#1464) Signed-off-by: Darshit Chanpura <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Cleaning up comments Signed-off-by: Leanne Lacey-Byrne <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * linting issues resolved Signed-off-by: leanneeliatra <[email protected]> * Removing Prerequisite Checks Workflow (opensearch-project#1456) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Removing Prerequisite Checks Workflow (opensearch-project#1456) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * Update server/multitenancy/tenant_resolver.ts Co-authored-by: Darshit Chanpura <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> * comments addressed & linting amended Signed-off-by: leanneeliatra <[email protected]> * integration test fix following rebase Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> --------- Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Leanne Lacey-Byrne <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit e9f9576)
DarshitChanpura
changed the title
Signed-off-by: Darshit Chanpura <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.3 #1516 +/- ##
=======================================
Coverage 72.48% 72.48%
=======================================
Files 88 88
Lines 1926 1926
Branches 246 246
=======================================
Hits 1396 1396
Misses 474 474
Partials 56 56 |
peternied
reviewed
Jul 19, 2023
| @@ -31,6 +31,13 @@ export const ERROR_MISSING_ROLE_PATH = '/missing-role'; | |||
|
|
|||
| export const MAX_INTEGER = 2147483647; | |||
|
|
|||
| export const GLOBAL_TENANT_SYMBOL = ''; | |||
cwperks
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backports e9f9576 from #1462.
Category
Bug fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.