[Backport 2.x] Fixing dynamic tenancy changes for issues 1412 (#1419) #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
force-pushed
the
backport/backport-1419-to-2.x
branch
from
fb88245 to
e3a3112
Compare
RyanL1997
approved these changes
May 31, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1458 +/- ##
==========================================
- Coverage 65.51% 65.47% -0.05%
==========================================
Files 93 93
Lines 2294 2297 +3
Branches 312 308 -4
==========================================
+ Hits 1503 1504 +1
- Misses 723 725 +2
Partials 68 68
|
cwperks
reviewed
May 31, 2023
| START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch --opensearch_security.multitenancy.enable_aggregation_view=true' | ||
| OPENSEARCH_SNAPSHOT_CMD: 'node ../scripts/opensearch snapshot' | ||
| SPEC: 'cypress/integration/plugins/security-dashboards-plugin/aggregation_view.js,' | ||
| OPENSEARCH_VERSION: 3.0.0 |
There was a problem hiding this comment.
These versions need to match the version in package.json.
cwperks
reviewed
May 31, 2023
| SPEC: 'cypress/integration/plugins/security-dashboards-plugin/aggregation_view.js,' | ||
| OPENSEARCH_VERSION: 3.0.0 | ||
| PLUGIN_NAME: opensearch-security | ||
| PLUGIN_VERSION: 3.0.0.0 |
|
@DarshitChanpura Please include the changes from this PR in the cypress workflow introduced in this PR. |
* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml Signed-off-by: Abhi Kalra <[email protected]> Co-authored-by: Abhi Kalra <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> (cherry picked from commit c4e6c37) Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
backport/backport-1419-to-2.x
branch
from
e3a3112 to
eb62c99
Compare
|
Done. |
Signed-off-by: Darshit Chanpura <[email protected]>
|
Why are the cypress tests failing to find |
cwperks
reviewed
Jun 16, 2023
| echo "PLUGIN_VERSION=$plugin_version" >> $GITHUB_ENV | ||
| shell: bash | ||
|
|
||
| - name: Checkout Branch |
There was a problem hiding this comment.
I think this needs to be before Set env.
There was a problem hiding this comment.
That's what it is on main: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/workflows/cypress-test-tenancy-disabled.yml#L29-L38
@DarshitChanpura Can you update?
Signed-off-by: Darshit Chanpura <[email protected]>
cwperks
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #1419
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.