-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in jwt url parameter by awaiting async getAdditionalAuthHeader #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to async Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DarshitChanpura
previously approved these changes
Jan 9, 2023
RyanL1997
reviewed
Jan 9, 2023
RyanL1997
added
backport 2.x
backport to 2.x branch
backport 2.4
backport to 2.4 branch
backport 2.5
backport to 2.5 branch
labels
Jan 10, 2023
Signed-off-by: Ryan Liang <[email protected]>
cwperks
commented
Jan 10, 2023
Signed-off-by: Ryan Liang <[email protected]>
DarshitChanpura
previously approved these changes
Jan 10, 2023
Signed-off-by: Ryan Liang <[email protected]>
peternied
approved these changes
Jan 10, 2023
cliu123
approved these changes
Jan 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
…thHeader (#1292) * Fix issue with jwt as url param after getAdditionalAuthHeader switched to async Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 385377c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
…thHeader (#1292) * Fix issue with jwt as url param after getAdditionalAuthHeader switched to async Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 385377c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
…thHeader (#1292) * Fix issue with jwt as url param after getAdditionalAuthHeader switched to async Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 385377c)
RyanL1997
pushed a commit
that referenced
this pull request
Jan 11, 2023
…thHeader (#1292) (#1296) * Fix issue with jwt as url param after getAdditionalAuthHeader switched to async Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 385377c)
RyanL1997
pushed a commit
that referenced
this pull request
Jan 18, 2023
…thHeader (#1292) (#1294) * Fix issue with jwt as url param after getAdditionalAuthHeader switched to async Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 385377c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
backport to 2.x branch
backport 2.4
backport to 2.4 branch
backport 2.5
backport to 2.5 branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A regression was introduced into JWT auth in the 2.4.0 release that prevented authentication with the JWT backend via the url param due to a signature change in the
getAdditionalAuthHeader
function. See this comment for details: #872 (comment)This PR introduces a file called
after_env.js
which is needed to get beyond an issueReferenceError: TextEncoder is not defined
when trying to importSignJWT
from jose.The solution was suggested here: inrupt/solid-client-authn-js#1676 (comment)
I'm not sure if this is the best way to get beyond the problem and open to anyone's suggestions.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Bug Fix
Issues Resolved
#872
Testing
Added new selenium tests directly in this PR.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.