Add Notifications cluster permissions #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Qureshi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
approved these changes
Jan 6, 2023
RyanL1997
approved these changes
Jan 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
Signed-off-by: Mohammad Qureshi <[email protected]> (cherry picked from commit 180f694)
RyanL1997
pushed a commit
that referenced
this pull request
Jan 6, 2023
Signed-off-by: Mohammad Qureshi <[email protected]> (cherry picked from commit 180f694)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Qureshi [email protected]
Description
When Notifications launched in 2.0, the cluster permissions were added to the pre-defined roles in the backend but the cluster permission constants were not updated in the Security Dashboards frontend. This is needed for users who create custom roles with cluster permissions from the UI.
If not backported to older versions, please at least include this in
mainand2.xso that this can be included in the upcoming 2.5 release.Category
Bug fix
Why these changes are required?
Security Dashboards populates the cluster permissions options through a constant variable. All available cluster permissions should be included in this constant list.
Issues Resolved
opensearch-project/notifications#541
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.