Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Emeritus folks to maintainer list. #1131

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

CEHENKLE
Copy link
Member

@CEHENKLE CEHENKLE commented Oct 6, 2022

Description

This is a PR to add Yan, Bandini and Tianle to the maintainers list as emeritus to recognize their contribution to the creation of the repo in 2021. This action does not change the active maintainers list, or add any current permissions (but would love for them to become active again)!"

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… recognize their contribution to the creation of the repo in 2021. This action does not change the active maintainers list, or add any current permissions (but would love for them to become active again)!

Signed-off-by: CEHENKLE <[email protected]>
Signed-off-by: CEHENKLE <[email protected]>
@CEHENKLE CEHENKLE requested a review from a team October 6, 2022 00:37
@CEHENKLE
Copy link
Member Author

CEHENKLE commented Oct 6, 2022

Hey folks -- I'm not a maintainer on this repo, so it's up to the current maintainers to decide if they want to accept this PR to amend the historical record.

Thanks,
/C

@seraphjiang
Copy link
Member

Thanks @CEHENKLE
May I suggest to add Yan to maintainer list, he is actively leading the security dashboards plugin :)

@codecov-commenter
Copy link

Codecov Report

Merging #1131 (71c60df) into main (42a55e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   74.43%   74.43%           
=======================================
  Files          86       86           
  Lines        1874     1874           
  Branches      244      244           
=======================================
  Hits         1395     1395           
  Misses        424      424           
  Partials       55       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CEHENKLE
Copy link
Member Author

CEHENKLE commented Oct 6, 2022

Thanks @CEHENKLE May I suggest to add Yan to maintainer list, he is actively leading the security dashboards plugin :)

The policy to add maintainers is here : https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md Since we adopted this policy 6 months ago, all new active maintainers -- internal and external -- should be added using it.

I'm really looking forward to seeing Yan's contributions in the repo, but as I mentioned above, I'm not a maintainer on this repo. A current maintainer will need to nominate him and then the maintainers will vote per the policy.

Thanks,
/C

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for recognizing the contributions, well earned!

@cliu123 cliu123 merged commit 729cd67 into opensearch-project:main Oct 6, 2022
@davidlago
Copy link

Thank you Yan, Bandini and Tianle! Happy to have you inaugurate our emeritus list, well deserved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants