Fix the UI user flow of selecting custom teanant on tenant switch panel #1112

RyanL1997 · 2022-09-29T18:40:19Z

Signed-off-by: Ryan Liang [email protected]

Description

Add description into the custom tenant selecting dropdown list, and disable the button when there is no valid selection for custom tenant.
Update the unit test.

Issues Resolved

Resolved No warning or error message displays when no tenant is chosen under choose from custom option #819

Testing

Check List

New functionality includes testing
~~New functionality has been documented~~
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter · 2022-09-30T03:49:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (bf5691f) to head (f27aafc).
Report is 208 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   74.39%   74.43%   +0.04%     
==========================================
  Files          86       86              
  Lines        1871     1874       +3     
  Branches      241      244       +3     
==========================================
+ Hits         1392     1395       +3     
  Misses        424      424              
  Partials       55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RyanL1997 · 2022-09-30T13:56:09Z

Hi @shanilpa, thank you for the instruction: #819 (comment). The fix has been implemented.

peternied

Looks fine to me, might need some work to get the CI working

RyanL1997 · 2022-09-30T19:32:37Z

Looks fine to me, might need some work to get the CI working

Hi @peternied, thanks for the review. I just fixed the tests.

DarshitChanpura

Thanks @RyanL1997 !

peternied · 2022-09-30T21:57:04Z

public/apps/account/tenant-switch-panel.tsx

@@ -297,8 +298,18 @@ export function TenantSwitchPanel(props: TenantSwitchPanelProps) {

          <EuiButton
            data-test-subj="confirm"
-            fill
-            disabled={!isMultiTenancyEnabled}
+            fill={


Can we move the logic into a local variable it is not duplicated it on both lines?

Thanks for the review! I just made an update on this.

cwperks · 2022-10-03T14:33:15Z

public/apps/account/tenant-switch-panel.tsx

@@ -297,8 +301,8 @@ export function TenantSwitchPanel(props: TenantSwitchPanelProps) {

          <EuiButton
            data-test-subj="confirm"
-            fill
-            disabled={!isMultiTenancyEnabled}
+            fill={isMultiTenancyEnabled && !invalidCustomTenant}


I see we've now added a condition on fill here. I just want to confirm if this is intended behavior.

fill is related to whether the bg of the button is filled in or transparent. See https://eui.elastic.co/pr_3350/#/navigation/button

Hi @cwperks, thanks for the review! I talked to @shanilpa, and he suggested me to change the disabled button to the ghosted disabled without the fill option, because that's the pattern we are moving forward with. That's why I added the condition to the fill option.

@RyanL1997 that's correct. We're looking to reduce some of the visual clutter by making use of the ghosted disabled state. Thanks for the review @cwperks.

cwperks · 2022-10-04T13:56:41Z

@RyanL1997 Looks like this branch needs to be re-based, please re-base with the latest changes in main. Should this change be backported to 2.x?

Signed-off-by: Ryan Liang <[email protected]>

RyanL1997 · 2022-10-04T14:13:59Z

@RyanL1997 Looks like this branch needs to be re-based, please re-base with the latest changes in main. Should this change be backported to 2.x?

@cwperks Thanks! I just re-pushed with the rebased repo. Yeah, I think we do need to add the 2.x backporting label.

…el (#1112) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 3bfd7c5)

…el (#1112) (#1117) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 3bfd7c5) Co-authored-by: Ryan Liang <[email protected]>

RyanL1997 force-pushed the bugfix819 branch 4 times, most recently from 29e5233 to 79a3020 Compare September 30, 2022 03:39

RyanL1997 marked this pull request as ready for review September 30, 2022 13:49

RyanL1997 requested a review from a team September 30, 2022 13:49

RyanL1997 force-pushed the bugfix819 branch from 79a3020 to 04c1fd9 Compare September 30, 2022 16:10

peternied previously approved these changes Sep 30, 2022

View reviewed changes

RyanL1997 dismissed peternied’s stale review via f1a9d30 September 30, 2022 16:25

RyanL1997 force-pushed the bugfix819 branch 2 times, most recently from f1a9d30 to 563cef0 Compare September 30, 2022 16:40

DarshitChanpura previously approved these changes Sep 30, 2022

View reviewed changes

peternied reviewed Sep 30, 2022

View reviewed changes

RyanL1997 dismissed DarshitChanpura’s stale review via 548f999 October 1, 2022 04:00

RyanL1997 force-pushed the bugfix819 branch 5 times, most recently from f68680d to 9565e3d Compare October 1, 2022 04:59

cwperks reviewed Oct 3, 2022

View reviewed changes

peternied previously approved these changes Oct 3, 2022

View reviewed changes

cwperks previously approved these changes Oct 4, 2022

View reviewed changes

Fix the UI user flow of selecting custom teanant on tenant switch panel

f27aafc

Signed-off-by: Ryan Liang <[email protected]>

RyanL1997 dismissed stale reviews from cwperks and peternied via f27aafc October 4, 2022 14:11

RyanL1997 force-pushed the bugfix819 branch from 9565e3d to f27aafc Compare October 4, 2022 14:11

cwperks added the backport 2.x backport to 2.x branch label Oct 4, 2022

cwperks approved these changes Oct 4, 2022

View reviewed changes

peternied approved these changes Oct 4, 2022

View reviewed changes

peternied merged commit 3bfd7c5 into opensearch-project:main Oct 4, 2022

opensearch-trigger-bot bot mentioned this pull request Oct 4, 2022

[Backport 2.x] Fix the UI user flow of selecting custom teanant on tenant switch panel #1117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the UI user flow of selecting custom teanant on tenant switch panel #1112

Fix the UI user flow of selecting custom teanant on tenant switch panel #1112

RyanL1997 commented Sep 29, 2022 •

edited

Loading

codecov-commenter commented Sep 30, 2022 •

edited by codecov bot

Loading

RyanL1997 commented Sep 30, 2022

peternied left a comment

RyanL1997 commented Sep 30, 2022 •

edited

Loading

DarshitChanpura left a comment

peternied Sep 30, 2022

RyanL1997 Oct 3, 2022

cwperks Oct 3, 2022

RyanL1997 Oct 3, 2022 •

edited

Loading

shanilpa Oct 3, 2022

cwperks commented Oct 4, 2022

RyanL1997 commented Oct 4, 2022

Fix the UI user flow of selecting custom teanant on tenant switch panel #1112

Fix the UI user flow of selecting custom teanant on tenant switch panel #1112

Conversation

RyanL1997 commented Sep 29, 2022 • edited Loading

Description

Category

Issues Resolved

Testing

Check List

codecov-commenter commented Sep 30, 2022 • edited by codecov bot Loading

Codecov Report

RyanL1997 commented Sep 30, 2022

peternied left a comment

Choose a reason for hiding this comment

RyanL1997 commented Sep 30, 2022 • edited Loading

DarshitChanpura left a comment

Choose a reason for hiding this comment

peternied Sep 30, 2022

Choose a reason for hiding this comment

RyanL1997 Oct 3, 2022

Choose a reason for hiding this comment

cwperks Oct 3, 2022

Choose a reason for hiding this comment

RyanL1997 Oct 3, 2022 • edited Loading

Choose a reason for hiding this comment

shanilpa Oct 3, 2022

Choose a reason for hiding this comment

cwperks commented Oct 4, 2022

RyanL1997 commented Oct 4, 2022

RyanL1997 commented Sep 29, 2022 •

edited

Loading

codecov-commenter commented Sep 30, 2022 •

edited by codecov bot

Loading

RyanL1997 commented Sep 30, 2022 •

edited

Loading

RyanL1997 Oct 3, 2022 •

edited

Loading