-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get security_tenant search param from URL #1024
Get security_tenant search param from URL #1024
Conversation
Signed-off-by: cliu123 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 72.27% 72.27%
=======================================
Files 87 87
Lines 1915 1915
Branches 249 249
=======================================
Hits 1384 1384
Misses 478 478
Partials 53 53 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we treat the source of this url, see the inline comment for more details
Signed-off-by: cliu123 <[email protected]> (cherry picked from commit 348c550)
Signed-off-by: cliu123 <[email protected]> (cherry picked from commit 348c550) Co-authored-by: Chang Liu <[email protected]>
Signed-off-by: cliu123 <[email protected]> Signed-off-by: Vasile Negru <[email protected]>
Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: cliu123 [email protected]
Description
The root cause of the issue is that the search param(
security_tenant
) in the URL is not captured.Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] Bug fix
Issues Resolved
#1012
Testing
{"statusCode":404,"error":"Not Found","message":"Saved object [url/<saved_object_id>] not found"}
)Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.