-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for account-nav-button when multitenancy is disabled #1020
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
+ Coverage 72.21% 72.27% +0.05%
==========================================
Files 87 87
Lines 1915 1915
Branches 249 249
==========================================
+ Hits 1383 1384 +1
Misses 478 478
+ Partials 54 53 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up the description, while this isn't required it would make it easier to parse and understand what this change accomplishes:
GITHUB-DESCRIPTION 1020.diff
Produced: 7/1/2022 11:57:34 AM
Mode: All, Ignoring Unimportant
Left file: C:\Users\petern\Desktop\1.txt Right file: C:\Users\petern\Desktop\2.txt
SUBJECT: Add tests for account-nav-button when multitenancy is disabled #1020 = SUBJECT: Add tests for account-nav-button when multitenancy is disabled #1020
BODY: BODY:
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Signed-off-by: Craig Perkins <[email protected]> +-
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
### Description ### Description
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[Describe what this change achieves] +-
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
This adds a test for [#965](https://github.com/opensearch-project/security-dashboards-plugin/pull/965) which is described in this issue [975](https://github.com/opensearch-project/security-dashboards-plugin/issues/975) This adds a test for [#965](https://github.com/opensearch-project/security-dashboards-plugin/pull/965) which is described in this issue [975](https://github.com/opensearch-project/security-dashboards-plugin/issues/975)
When multitenancy is disabled in `opensearch_dashboards.yml` the user should not be prompted with the tenant modal. When multitenancy is disabled in `opensearch_dashboards.yml` the user should not be prompted with the tenant modal.
### Category ### Category
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] <>
Test fix
### Why these changes are required?
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
### What is the old behavior before changes and new behavior after changes? +-
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
### Issues Resolved ### Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)] [List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
<> - Resolves #975
This resolves issue [975](https://github.com/opensearch-project/security-dashboards-plugin/issues/975).
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
### Testing +-
[Please provide details of testing done: unit testing, integration testing and manual testing]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
=
### Check List ### Check List
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [ ] New functionality includes testing <> - [X] New functionality includes testing
- [ ] New functionality has been documented - [ ] ~New functionality has been documented~
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [X] Commits are signed per the DCO using --signoff = - [X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. Please resolve the only pending comment at this moment, so we can merge it. Thanks!
Signed-off-by: Craig Perkins <[email protected]>
c62e56e
to
4b77770
Compare
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 4527d1a)
#1022) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 4527d1a) Co-authored-by: Craig Perkins <[email protected]>
…earch-project#1020) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Vasile Negru <[email protected]>
Signed-off-by: Craig Perkins [email protected]
Description
This adds a test for #965 which is described in this issue 975
When multitenancy is disabled in
opensearch_dashboards.yml
the user should not be prompted with the tenant modal.Category
New Tests
Issues Resolved
This resolves issue 975.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.