Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Increment to 1.3.3 OpenSearch Dashboard release #1005

Merged

Conversation

prudhvigodithi
Copy link
Member

Signed-off-by: pgodithi [email protected]

Description

opensearch-project/opensearch-build#2101

Category

N/A

Why these changes are required?

opensearch-project/opensearch-build#2101

Issues Resolved

opensearch-project/opensearch-build#2101

Testing

N/A

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <[email protected]>
Signed-off-by: pgodithi <[email protected]>
@peternied peternied marked this pull request as ready for review June 2, 2022 17:00
@peternied peternied requested a review from a team June 2, 2022 17:00
@peternied peternied marked this pull request as draft June 2, 2022 17:01
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prudhvigodithi Please let me know when this PR is OK to be merged for 1.3.3, thanks.

@cliu123 cliu123 marked this pull request as ready for review June 2, 2022 18:05
@cliu123
Copy link
Member

cliu123 commented Jun 2, 2022

This PR is blocked by #1006.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #1005 (bd6ae24) into 1.3 (c4a830c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.3    #1005   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      247      247           
=======================================
  Hits         1372     1372           
  Misses        480      480           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a830c...bd6ae24. Read the comment docs.

@prudhvigodithi
Copy link
Member Author

Hey @peternied and @cliu123 if you are good with this PR change, please proceed to merge.
Thank you

@peternied
Copy link
Member

@prudhvigodithi This change cannot be merged until we get a new build of 1.3.3 that includes the security plugin, please let us know when 1.3.3 has built completes so the integration tests can be re-run successfully

@@ -44,7 +44,7 @@ jobs:
with:
path: OpenSearch-Dashboards
repository: opensearch-project/OpenSearch-Dashboards
ref: '1.3.2'
ref: '1.3.3'
Copy link
Member

@cliu123 cliu123 Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSearch Dashboards hasn't cut 1.3.3 tag, so the integration tests failed.

@DarshitChanpura DarshitChanpura merged commit 430e6cf into opensearch-project:1.3 Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants