Delete detector successfully if workflow is missing (#790)

[engechas]

• Delete detector successfully if workflow is missing

Signed-off-by: Chase Engelbrecht [email protected]

• Refactor to use existing NotFound exception checker

Signed-off-by: Chase Engelbrecht [email protected]

---

Signed-off-by: Chase Engelbrecht [email protected]
(cherry picked from commit 0ad91cc)

Description

Manual conflict resolution + backport

Check List

• New functionality includes testing.
  • All tests pass
• [N/A] New functionality has been documented.
  • [N/A] New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[jowg-amazon]

Can you rebase from 2.x? Checks are failing because of the gradle update.

[engechas]

Can you rebase from 2.x? Checks are failing because of the gradle update.

Done

[codecov]

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8990aed) 24.83% compared to head (ac2255b) 24.82%.

Files	Patch %	Lines
...ytics/transport/TransportDeleteDetectorAction.java	0.00%	13 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x     #809      +/-   ##
============================================
- Coverage     24.83%   24.82%   -0.02%     
  Complexity     1024     1024              
============================================
  Files           277      277              
  Lines         12683    12689       +6     
  Branches       1389     1389              
============================================
  Hits           3150     3150              
- Misses         9267     9273       +6     
  Partials        266      266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[engechas]

Can you rebase from 2.x? Checks are failing because of the gradle update.

Done

Nvm, still failing. It doesn't look related to this PR but will investigate soon

[engechas]

This is the failure:

org.opensearch.securityanalytics.findings.FindingIT > testGetFindings_rolloverByMaxAge_success FAILED
    java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
        at __randomizedtesting.SeedInfo.seed([C511499764CAA34E:81FC4FA1CAEA296F]:0)
        at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
        at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
        at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
        at java.base/java.util.Objects.checkIndex(Objects.java:374)
        at java.base/java.util.ArrayList.get(ArrayList.java:459)
        at org.opensearch.securityanalytics.findings.FindingIT.testGetFindings_rolloverByMaxAge_success(FindingIT.java:325)

I confirmed it still occurs with my backported commit removed.

[jowg-amazon]

Yeah this is a known flakey test in SA. I'm taking a look into it now.