Upgrade Lucene Codec to Lucene99 + Upgrade to Gradle 8.5

[jowg-amazon]

Description

This PR includes the following changes:

• Add new codec that wraps Lucene Codec 99 and make it default

• Fix import statements for Lucene Codec 95

• Change CorrelationCode990 and CorrelationCodec950 constructor to type PerFieldKnnVectorsFormat to abstract the field type.

• Upgrades to gradle 8.5

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0ad91cc) 24.73% compared to head (e0d775b) 24.78%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
...rrelation/index/codec/CorrelationCodecVersion.java	75.00%	2 Missing ⚠️
...lation990/PerFieldCorrelationVectorsFormat990.java	50.00%	2 Missing ⚠️
...ndex/codec/correlation990/CorrelationCodec990.java	85.71%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #800      +/-   ##
============================================
+ Coverage     24.73%   24.78%   +0.05%     
- Complexity     1023     1027       +4     
============================================
  Files           275      277       +2     
  Lines         12695    12709      +14     
  Branches       1400     1400              
============================================
+ Hits           3140     3150      +10     
- Misses         9290     9294       +4     
  Partials        265      265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eirsep]

why do we need both old and new codec? what was the previous code being used?

[eirsep]

are there any backward compatibility issues when customer upgrades from a version with previous codec to this?

[jowg-amazon]

Asked @sbcd90 yesterday about keeping the old codec and he said it would be good to keep. K-nn keeps their old codecs for backwards compatibility which is why I kept both old and new codec. Don't know how to test this as we don't have a BWC workflow set up yet.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-800-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 988377a5f26cb7eedf13cb075a8e9624c29b78a8
# Push it to GitHub
git push --set-upstream origin backport/backport-800-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-800-to-2.x.