Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeowners to match maintainers #783

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

dtaivpp
Copy link
Contributor

@dtaivpp dtaivpp commented Dec 11, 2023

Description

Fix codeowners to match maintainers as AWSHurneyt was put in and didn't match the entry in the Maintainers file.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c373343) 24.74% compared to head (cea43cf) 24.74%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #783   +/-   ##
=========================================
  Coverage     24.74%   24.74%           
  Complexity     1023     1023           
=========================================
  Files           275      275           
  Lines         12689    12689           
  Branches       1400     1400           
=========================================
  Hits           3140     3140           
  Misses         9284     9284           
  Partials        265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtaivpp
Copy link
Contributor Author

dtaivpp commented Dec 14, 2023

@getsaurabh02 could you look over this?

@dblock
Copy link
Member

dblock commented Jan 4, 2024

Can we please merge this?

@jowg-amazon jowg-amazon merged commit 1dd6c2d into opensearch-project:main Jan 4, 2024
11 of 16 checks passed
jowg-amazon pushed a commit to jowg-amazon/security-analytics that referenced this pull request Jan 10, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-783-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1dd6c2d4c11af237df261731bf2b4069c6adf020
# Push it to GitHub
git push --set-upstream origin backport/backport-783-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-783-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 19, 2024
Signed-off-by: David Tippett <[email protected]>
(cherry picked from commit 1dd6c2d)
jowg-amazon pushed a commit that referenced this pull request Feb 5, 2024
Signed-off-by: David Tippett <[email protected]>
(cherry picked from commit 1dd6c2d)

Co-authored-by: David Tippett <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…search-project#783)

* support more cases for detection; use code editor for condition

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed cypress tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants