Allow deletion of custom log type if custom rule index is missing (#767) #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensearch-project#767) * Allow deletion of custom log type if custom rule index is missing Signed-off-by: Megha Goyal <[email protected]> * Allow custom log type name to be updated when custom rule index is missing Signed-off-by: Megha Goyal <[email protected]> * Adding changes for detector index missing Signed-off-by: Megha Goyal <[email protected]> * Update log type when detector index is missing Signed-off-by: Megha Goyal <[email protected]> --------- Signed-off-by: Megha Goyal <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.11-with-features #780 +/- ##
========================================================
+ Coverage 24.58% 24.61% +0.03%
+ Complexity 948 945 -3
========================================================
Files 255 255
Lines 11422 11395 -27
Branches 1289 1290 +1
========================================================
- Hits 2808 2805 -3
+ Misses 8366 8341 -25
- Partials 248 249 +1 ☔ View full report in Codecov by Sentry. |
jowg-amazon
approved these changes
Dec 8, 2023
praveensameneni
approved these changes
Dec 8, 2023
jowg-amazon
merged commit 1161d9c
into
opensearch-project:2.11-with-features
10 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case when the custom rule index is missing, we want to allow the update/deletion of custom log types to be successful instead of throwing an error. The detector index may not be present, and the custom log types will still get updated/deleted respectively.
Backport #767
Issues Resolved
#700
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.