Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updation/deletion of custom log type if custom rule index is mi… #779

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

goyamegh
Copy link
Collaborator

@goyamegh goyamegh commented Dec 8, 2023

Backport (#767)

Description

[Describe what this change achieves]

Issues Resolved

#700

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (48c2cfa) 24.67% compared to head (af55c64) 24.72%.

Files Patch % Lines
...s/transport/TransportIndexCustomLogTypeAction.java 0.00% 54 Missing ⚠️
.../transport/TransportDeleteCustomLogTypeAction.java 0.00% 34 Missing ⚠️
...opensearch/securityanalytics/util/RuleIndices.java 0.00% 12 Missing ⚠️
...analytics/transport/TransportDeleteRuleAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #779      +/-   ##
============================================
+ Coverage     24.67%   24.72%   +0.05%     
  Complexity      947      947              
============================================
  Files           255      255              
  Lines         11374    11347      -27     
  Branches       1279     1280       +1     
============================================
  Hits           2806     2806              
+ Misses         8319     8292      -27     
  Partials        249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit 69e5290 into opensearch-project:2.11 Dec 8, 2023
12 of 15 checks passed
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
…y index (opensearch-project#779)

* Adjusting max field index setting dynamically for query index (opensearch-project#776)

* added adjusting max field index setting dynamicly for query index

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit c9d84cbbeb23cc1cb783976c1f7f563c522104de)

* Remove 3.0 required changes

Signed-off-by: Ashish Agrawal <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants