add category to custom log types #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbcd90
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni and
eirsep
as code owners
Signed-off-by: Subhobrata Dey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
============================================
- Coverage 25.04% 25.01% -0.04%
Complexity 943 943
============================================
Files 255 255
Lines 11123 11139 +16
Branches 1242 1246 +4
============================================
Hits 2786 2786
- Misses 8086 8102 +16
Partials 251 251
|
amsiglan
previously approved these changes
Oct 4, 2023
lezzago
reviewed
Oct 4, 2023
| @@ -44,6 +57,8 @@ public class CustomLogType implements Writeable, ToXContentObject { | |||
|
|
|||
| private String description; | |||
|
|
|||
| private String category; | |||
There was a problem hiding this comment.
This is not an optional parameter, we need this to have a default value for users upgrading the cluster or this will cause issues for them.
There was a problem hiding this comment.
added a default value for category field.
Signed-off-by: Subhobrata Dey <[email protected]>
amsiglan
approved these changes
Oct 4, 2023
lezzago
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 5781c85)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Subhobrata Dey <[email protected]> (cherry picked from commit 5781c85)
sbcd90
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add category to custom log types
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.